This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: Channel pain points #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordOfPolls
added
Bug::Library
silasary
approved these changes
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
This PR fixes 2 issues with channel objects.
Firstly, not all channel objects were calling their parent class dict processor. This resolved that.
Secondly, a minor ux pain point was found where when iterating over channels, threads didnt have a
permission_overwritesattribute. Now while this is technically correct, its a pain point. This resolves that too.Changes
permission_overwritesproperty to threadsChecklist
Python 3.10.x